Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1739484 Update golang version #1223

Merged
merged 1 commit into from
Oct 17, 2024
Merged

SNOW-1739484 Update golang version #1223

merged 1 commit into from
Oct 17, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Oct 16, 2024 •
edited
Loading

Description

SNOW-1739484 Support Go 1.23, drop support for Go 1.20

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1739484-update-go branch 2 times, most recently from a4cd0c4 to c27afd0 Compare October 16, 2024 11:55
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (8224d28) to head (c27afd0).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files          54       54           
  Lines       12916    12916           
=======================================
+ Hits        10670    10671    +1     
+ Misses       2246     2245    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review October 17, 2024 05:34
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 17, 2024 05:34
@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) October 17, 2024 11:26
@sfc-gh-pfus sfc-gh-pfus merged commit 251a6cd into master Oct 17, 2024
33 of 37 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1739484-update-go branch October 17, 2024 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-pbulawa @sfc-gh-dheyman-1 @sfc-gh-mkubik